real_path: remove unsafe API
Returning a shared buffer invites very subtle bugs due to reentrancy or multi-threading, as demonstrated by the previous patch. There was an unfinished effort to abolish this [1]. Let's finally rid of `real_path()`, using `strbuf_realpath()` instead. This patch uses a local `strbuf` for most places where `real_path()` was previously called. However, two places return the value of `real_path()` to the caller. For them, a `static` local `strbuf` was added, effectively pushing the problem one level higher: read_gitfile_gently() get_superproject_working_tree() [1] https://lore.kernel.org/git/1480964316-99305-1-git-send-email-bmwill@google.com/ Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
0915a5b4cd
commit
3d7747e318
2
path.c
2
path.c
@ -723,7 +723,7 @@ static struct passwd *getpw_str(const char *username, size_t len)
|
||||
* then it is a newly allocated string. Returns NULL on getpw failure or
|
||||
* if path is NULL.
|
||||
*
|
||||
* If real_home is true, real_path($HOME) is used in the expansion.
|
||||
* If real_home is true, strbuf_realpath($HOME) is used in the expansion.
|
||||
*/
|
||||
char *expand_user_path(const char *path, int real_home)
|
||||
{
|
||||
|
Reference in New Issue
Block a user