submodule init: initialize active submodules
Teach `submodule init` to initialize submodules which have been configured to be active by setting 'submodule.active' with a pathspec. Now if no path arguments are given and 'submodule.active' is configured, `init` will initialize all submodules which have been configured to be active. If no path arguments are given and 'submodule.active' is not configured, then `init` will retain the old behavior of initializing all submodules. This allows users to record more complex patterns as it saves retyping them whenever you invoke update. Signed-off-by: Brandon Williams <bmwill@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
a086f921a7
commit
3e7eaed016
@ -270,6 +270,29 @@ static int module_list_compute(int argc, const char **argv,
|
||||
return result;
|
||||
}
|
||||
|
||||
static void module_list_active(struct module_list *list)
|
||||
{
|
||||
int i;
|
||||
struct module_list active_modules = MODULE_LIST_INIT;
|
||||
|
||||
gitmodules_config();
|
||||
|
||||
for (i = 0; i < list->nr; i++) {
|
||||
const struct cache_entry *ce = list->entries[i];
|
||||
|
||||
if (!is_submodule_initialized(ce->name))
|
||||
continue;
|
||||
|
||||
ALLOC_GROW(active_modules.entries,
|
||||
active_modules.nr + 1,
|
||||
active_modules.alloc);
|
||||
active_modules.entries[active_modules.nr++] = ce;
|
||||
}
|
||||
|
||||
free(list->entries);
|
||||
*list = active_modules;
|
||||
}
|
||||
|
||||
static int module_list(int argc, const char **argv, const char *prefix)
|
||||
{
|
||||
int i;
|
||||
@ -420,6 +443,13 @@ static int module_init(int argc, const char **argv, const char *prefix)
|
||||
if (module_list_compute(argc, argv, prefix, &pathspec, &list) < 0)
|
||||
return 1;
|
||||
|
||||
/*
|
||||
* If there are no path args and submodule.active is set then,
|
||||
* by default, only initialize 'active' modules.
|
||||
*/
|
||||
if (!argc && git_config_get_value_multi("submodule.active"))
|
||||
module_list_active(&list);
|
||||
|
||||
for (i = 0; i < list.nr; i++)
|
||||
init_submodule(list.entries[i]->name, prefix, quiet);
|
||||
|
||||
|
Reference in New Issue
Block a user