git-compat-util: work around for access(X_OK) under root
On AIX, access(X_OK) may succeed when run as root even if the execution isn't possible. This behavior is allowed by POSIX which says: ... for a process with appropriate privileges, an implementation may indicate success for X_OK even if execute permission is not granted to any user. It can lead hook programs to have their execution refused: git commit -m content fatal: cannot exec '.git/hooks/pre-commit': Permission denied Add NEED_ACCESS_ROOT_HANDLER in order to use an access helper function. It checks with stat if any executable flags is set when the current user is root. Signed-off-by: Clément Chigot <clement.chigot@atos.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
ee662bf5c6
commit
400caafb2b
@ -1236,12 +1236,22 @@ struct tm *git_gmtime_r(const time_t *, struct tm *);
|
||||
|
||||
#ifdef FILENO_IS_A_MACRO
|
||||
int git_fileno(FILE *stream);
|
||||
# ifndef COMPAT_CODE
|
||||
# ifndef COMPAT_CODE_FILENO
|
||||
# undef fileno
|
||||
# define fileno(p) git_fileno(p)
|
||||
# endif
|
||||
#endif
|
||||
|
||||
#ifdef NEED_ACCESS_ROOT_HANDLER
|
||||
int git_access(const char *path, int mode);
|
||||
# ifndef COMPAT_CODE_ACCESS
|
||||
# ifdef access
|
||||
# undef access
|
||||
# endif
|
||||
# define access(path, mode) git_access(path, mode)
|
||||
# endif
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Our code often opens a path to an optional file, to work on its
|
||||
* contents when we can successfully open it. We can ignore a failure
|
||||
|
||||
Reference in New Issue
Block a user