mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sequencer: always free "struct replay_opts"

Browse Source 
sequencer_post_commit_cleanup() initializes an instance of "struct
replay_opts" but does not call replay_opts_release(). Currently this
does not leak memory because the code paths called don't allocate any of
the struct members. That will change in the next commit so add call to
replay_opts_release() to prevent a memory leak in "git commit" that
breaks all of the leak free tests.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Phillip Wood
2024-04-18 14:14:05 +01:00
committed by Junio C Hamano
parent 2a60cb766e
commit 42aae6a49a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sequencer.c
View File

@ -2823,12 +2823,14 @@ void sequencer_post_commit_cleanup(struct repository *r, int verbose)
NULL, REF_NO_DEREF); NULL, REF_NO_DEREF);
if (!need_cleanup) if (!need_cleanup)
return; goto out;
if (!have_finished_the_last_pick()) if (!have_finished_the_last_pick())
return; goto out;
sequencer_remove_state(&opts); sequencer_remove_state(&opts);
out:
replay_opts_release(&opts);
} }
static void todo_list_write_total_nr(struct todo_list *todo_list) static void todo_list_write_total_nr(struct todo_list *todo_list)