teach index_fd to work with pipes
index_fd can now work with file descriptors that are not normal files but any readable file. If the given file descriptor is a regular file then mmap() is used; for other files, strbuf_read is used. The path parameter, which has been used as hint for filters, can be NULL now to indicate that the file should be hashed literally without any filter. The index_pipe function is removed as redundant. Signed-off-by: Dmitry Potapov <dpotapov@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
2b603260f3
commit
43df4f86e0
64
sha1_file.c
64
sha1_file.c
@ -2353,51 +2353,22 @@ int has_sha1_file(const unsigned char *sha1)
|
||||
return has_loose_object(sha1);
|
||||
}
|
||||
|
||||
int index_pipe(unsigned char *sha1, int fd, const char *type, int write_object)
|
||||
static int index_mem(unsigned char *sha1, void *buf, size_t size,
|
||||
int write_object, enum object_type type, const char *path)
|
||||
{
|
||||
struct strbuf buf;
|
||||
int ret;
|
||||
|
||||
strbuf_init(&buf, 0);
|
||||
if (strbuf_read(&buf, fd, 4096) < 0) {
|
||||
strbuf_release(&buf);
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (!type)
|
||||
type = blob_type;
|
||||
if (write_object)
|
||||
ret = write_sha1_file(buf.buf, buf.len, type, sha1);
|
||||
else
|
||||
ret = hash_sha1_file(buf.buf, buf.len, type, sha1);
|
||||
strbuf_release(&buf);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
int index_fd(unsigned char *sha1, int fd, struct stat *st, int write_object,
|
||||
enum object_type type, const char *path)
|
||||
{
|
||||
size_t size = xsize_t(st->st_size);
|
||||
void *buf = NULL;
|
||||
int ret, re_allocated = 0;
|
||||
|
||||
if (size)
|
||||
buf = xmmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0);
|
||||
close(fd);
|
||||
|
||||
if (!type)
|
||||
type = OBJ_BLOB;
|
||||
|
||||
/*
|
||||
* Convert blobs to git internal format
|
||||
*/
|
||||
if ((type == OBJ_BLOB) && S_ISREG(st->st_mode)) {
|
||||
if ((type == OBJ_BLOB) && path) {
|
||||
struct strbuf nbuf;
|
||||
strbuf_init(&nbuf, 0);
|
||||
if (convert_to_git(path, buf, size, &nbuf,
|
||||
write_object ? safe_crlf : 0)) {
|
||||
munmap(buf, size);
|
||||
buf = strbuf_detach(&nbuf, &size);
|
||||
re_allocated = 1;
|
||||
}
|
||||
@ -2407,12 +2378,33 @@ int index_fd(unsigned char *sha1, int fd, struct stat *st, int write_object,
|
||||
ret = write_sha1_file(buf, size, typename(type), sha1);
|
||||
else
|
||||
ret = hash_sha1_file(buf, size, typename(type), sha1);
|
||||
if (re_allocated) {
|
||||
if (re_allocated)
|
||||
free(buf);
|
||||
return ret;
|
||||
}
|
||||
if (size)
|
||||
return ret;
|
||||
}
|
||||
|
||||
int index_fd(unsigned char *sha1, int fd, struct stat *st, int write_object,
|
||||
enum object_type type, const char *path)
|
||||
{
|
||||
int ret;
|
||||
size_t size = xsize_t(st->st_size);
|
||||
|
||||
if (!S_ISREG(st->st_mode)) {
|
||||
struct strbuf sbuf;
|
||||
strbuf_init(&sbuf, 0);
|
||||
if (strbuf_read(&sbuf, fd, 4096) >= 0)
|
||||
ret = index_mem(sha1, sbuf.buf, sbuf.len, write_object,
|
||||
type, path);
|
||||
else
|
||||
ret = -1;
|
||||
strbuf_release(&sbuf);
|
||||
} else if (size) {
|
||||
void *buf = xmmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0);
|
||||
ret = index_mem(sha1, buf, size, write_object, type, path);
|
||||
munmap(buf, size);
|
||||
} else
|
||||
ret = index_mem(sha1, NULL, size, write_object, type, path);
|
||||
close(fd);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user