mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

transport: fix leak with transport helper URLs

Browse Source 
Transport URLs can be prefixed with "foo::", which would tell us that
the transport uses a remote helper called "foo". We extract the helper
name by `xstrndup()`ing the prefix before the double-colons, but never
free that string.

Fix this leak by assigning the result to a separate local variable that
we can then free upon returning.

Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2024-08-07 17:32:56 -07:00
parent 406f326d27
commit 448d51d549
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
transport.c
View File

@ -1115,6 +1115,7 @@ static struct transport_vtable builtin_smart_vtable = {
struct transport *transport_get(struct remote *remote, const char *url) struct transport *transport_get(struct remote *remote, const char *url)
{ {
const char *helper; const char *helper;
char *helper_to_free = NULL;
const char *p; const char *p;
struct transport *ret = xcalloc(1, sizeof(*ret)); struct transport *ret = xcalloc(1, sizeof(*ret));
@ -1139,10 +1140,11 @@ struct transport *transport_get(struct remote *remote, const char *url)
while (is_urlschemechar(p == url, *p)) while (is_urlschemechar(p == url, *p))
p++; p++;
if (starts_with(p, "::")) if (starts_with(p, "::"))
helper = xstrndup(url, p - url); helper = helper_to_free = xstrndup(url, p - url);
if (helper) { if (helper) {
transport_helper_init(ret, helper); transport_helper_init(ret, helper);
free(helper_to_free);
} else if (starts_with(url, "rsync:")) { } else if (starts_with(url, "rsync:")) {
die(_("git-over-rsync is no longer supported")); die(_("git-over-rsync is no longer supported"));
} else if (url_is_local_not_ssh(url) && is_file(url) && is_bundle(url, 1)) { } else if (url_is_local_not_ssh(url) && is_file(url) && is_bundle(url, 1)) {