Merge branch 'ab/detox-gettext-tests'

Get rid of "GETTEXT_POISON" support altogether, which may or may
not be controversial.

* ab/detox-gettext-tests:
  tests: remove uses of GIT_TEST_GETTEXT_POISON=false
  tests: remove support for GIT_TEST_GETTEXT_POISON
  ci: remove GETTEXT_POISON jobs
This commit is contained in:
Junio C Hamano
2021-02-10 14:48:33 -08:00
22 changed files with 29 additions and 173 deletions

View File

@ -1155,15 +1155,6 @@ static void die_bad_number(const char *name, const char *value)
if (!value)
value = "";
if (!strcmp(name, "GIT_TEST_GETTEXT_POISON"))
/*
* We explicitly *don't* use _() here since it would
* cause an infinite loop with _() needing to call
* use_gettext_poison(). This is why marked up
* translations with N_() above.
*/
die(bad_numeric, value, name, error_type);
if (!(cf && cf->name))
die(_(bad_numeric), value, name, _(error_type));