mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reflog expire: narrow scope of "cb" in cmd_reflog_expire()

Browse Source 
As with the preceding change for "reflog delete", change the "cb_data"
we pass to callbacks to be &cb.cmd itself, instead of passing &cb and
having the callback lookup cb->cmd.

This makes it clear that the "cb" itself is the same memzero'd
structure on each iteration of the for-loops that use &cb, except for
the "cmd" member.

The "struct expire_reflog_policy_cb" we pass to reflog_expire() will
have the members that aren't "cmd" modified by the callbacks, but
before we invoke them everything except "cmd" is zero'd out.

This included the "tip_commit", "mark_list" and "tips". It might have
looked as though we were re-using those between iterations, but the
first thing we did in reflog_expiry_prepare() was to either NULL them,
or clobber them with another value.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2021-12-22 05:06:41 +01:00
committed by Junio C Hamano
parent 4a0339b36f
commit 46fbe418b2
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
builtin/reflog.c
View File

@ -357,7 +357,6 @@ static void reflog_expiry_prepare(const char *refname,
struct expire_reflog_policy_cb *cb = cb_data; struct expire_reflog_policy_cb *cb = cb_data;
if (!cb->cmd.expire_unreachable || is_head(refname)) { if (!cb->cmd.expire_unreachable || is_head(refname)) {
cb->tip_commit = NULL;
cb->unreachable_expire_kind = UE_HEAD; cb->unreachable_expire_kind = UE_HEAD;
} else { } else {
cb->tip_commit = lookup_commit_reference_gently(the_repository, cb->tip_commit = lookup_commit_reference_gently(the_repository,
@ -371,8 +370,6 @@ static void reflog_expiry_prepare(const char *refname,
if (cb->cmd.expire_unreachable <= cb->cmd.expire_total) if (cb->cmd.expire_unreachable <= cb->cmd.expire_total)
cb->unreachable_expire_kind = UE_ALWAYS; cb->unreachable_expire_kind = UE_ALWAYS;
cb->mark_list = NULL;
cb->tips = NULL;
if (cb->unreachable_expire_kind != UE_ALWAYS) { if (cb->unreachable_expire_kind != UE_ALWAYS) {
if (cb->unreachable_expire_kind == UE_HEAD) { if (cb->unreachable_expire_kind == UE_HEAD) {
struct commit_list *elem; struct commit_list *elem;
@ -541,7 +538,7 @@ static void set_reflog_expiry_param(struct cmd_reflog_expire_cb *cb, int slot, c
static int cmd_reflog_expire(int argc, const char **argv, const char *prefix) static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
{ {
struct expire_reflog_policy_cb cb; struct cmd_reflog_expire_cb cmd = { 0 };
timestamp_t now = time(NULL); timestamp_t now = time(NULL);
int i, status, do_all, all_worktrees = 1; int i, status, do_all, all_worktrees = 1;
int explicit_expiry = 0; int explicit_expiry = 0;
@ -553,10 +550,9 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
save_commit_buffer = 0; save_commit_buffer = 0;
do_all = status = 0; do_all = status = 0;
memset(&cb, 0, sizeof(cb));
cb.cmd.expire_total = default_reflog_expire; cmd.expire_total = default_reflog_expire;
cb.cmd.expire_unreachable = default_reflog_expire_unreachable; cmd.expire_unreachable = default_reflog_expire_unreachable;
for (i = 1; i < argc; i++) { for (i = 1; i < argc; i++) {
const char *arg = argv[i]; const char *arg = argv[i];
@ -564,17 +560,17 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n")) if (!strcmp(arg, "--dry-run") || !strcmp(arg, "-n"))
flags |= EXPIRE_REFLOGS_DRY_RUN; flags |= EXPIRE_REFLOGS_DRY_RUN;
else if (skip_prefix(arg, "--expire=", &arg)) { else if (skip_prefix(arg, "--expire=", &arg)) {
if (parse_expiry_date(arg, &cb.cmd.expire_total)) if (parse_expiry_date(arg, &cmd.expire_total))
die(_("'%s' is not a valid timestamp"), arg); die(_("'%s' is not a valid timestamp"), arg);
explicit_expiry |= EXPIRE_TOTAL; explicit_expiry |= EXPIRE_TOTAL;
} }
else if (skip_prefix(arg, "--expire-unreachable=", &arg)) { else if (skip_prefix(arg, "--expire-unreachable=", &arg)) {
if (parse_expiry_date(arg, &cb.cmd.expire_unreachable)) if (parse_expiry_date(arg, &cmd.expire_unreachable))
die(_("'%s' is not a valid timestamp"), arg); die(_("'%s' is not a valid timestamp"), arg);
explicit_expiry |= EXPIRE_UNREACH; explicit_expiry |= EXPIRE_UNREACH;
} }
else if (!strcmp(arg, "--stale-fix")) else if (!strcmp(arg, "--stale-fix"))
cb.cmd.stalefix = 1; cmd.stalefix = 1;
else if (!strcmp(arg, "--rewrite")) else if (!strcmp(arg, "--rewrite"))
flags |= EXPIRE_REFLOGS_REWRITE; flags |= EXPIRE_REFLOGS_REWRITE;
else if (!strcmp(arg, "--updateref")) else if (!strcmp(arg, "--updateref"))
@ -600,14 +596,14 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
* even in older repository. We cannot trust what's reachable * even in older repository. We cannot trust what's reachable
* from reflog if the repository was pruned with older git. * from reflog if the repository was pruned with older git.
*/ */
if (cb.cmd.stalefix) { if (cmd.stalefix) {
repo_init_revisions(the_repository, &cb.cmd.revs, prefix); repo_init_revisions(the_repository, &cmd.revs, prefix);
cb.cmd.revs.do_not_die_on_missing_tree = 1; cmd.revs.do_not_die_on_missing_tree = 1;
cb.cmd.revs.ignore_missing = 1; cmd.revs.ignore_missing = 1;
cb.cmd.revs.ignore_missing_links = 1; cmd.revs.ignore_missing_links = 1;
if (flags & EXPIRE_REFLOGS_VERBOSE) if (flags & EXPIRE_REFLOGS_VERBOSE)
printf(_("Marking reachable objects...")); printf(_("Marking reachable objects..."));
mark_reachable_objects(&cb.cmd.revs, 0, 0, NULL); mark_reachable_objects(&cmd.revs, 0, 0, NULL);
if (flags & EXPIRE_REFLOGS_VERBOSE) if (flags & EXPIRE_REFLOGS_VERBOSE)
putchar('\n'); putchar('\n');
} }
@ -629,6 +625,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
free_worktrees(worktrees); free_worktrees(worktrees);
for (i = 0; i < collected.nr; i++) { for (i = 0; i < collected.nr; i++) {
struct collected_reflog *e = collected.e[i]; struct collected_reflog *e = collected.e[i];
struct expire_reflog_policy_cb cb = { .cmd = cmd };
set_reflog_expiry_param(&cb.cmd, explicit_expiry, e->reflog); set_reflog_expiry_param(&cb.cmd, explicit_expiry, e->reflog);
status |= reflog_expire(e->reflog, flags, status |= reflog_expire(e->reflog, flags,
@ -643,6 +640,8 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
for (; i < argc; i++) { for (; i < argc; i++) {
char *ref; char *ref;
struct expire_reflog_policy_cb cb = { .cmd = cmd };
if (!dwim_log(argv[i], strlen(argv[i]), NULL, &ref)) { if (!dwim_log(argv[i], strlen(argv[i]), NULL, &ref)) {
status |= error(_("%s points nowhere!"), argv[i]); status |= error(_("%s points nowhere!"), argv[i]);
continue; continue;