rev-list: fix --reverse interaction with --parents

--reverse did not interact well with --parents, as the included test
case shows: in a history like

  A--B.
   \   \
    `C--M--D

the command

  git rev-list --reverse --parents --full-history HEAD

erroneously lists D as having no parents at all.  (Without --reverse,
it correctly lists M.)

This is caused by the machinery driving --reverse: it first grabs all
commits through the normal routines, then runs them through the same
routines again, effectively simplifying them twice.

Fix this by moving the --reverse one level up, into get_revision().
This way we can cleanly grab all commits via the normal calls, then
just pop them off the list one by one without interfering with
get_revision_internal().

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Thomas Rast
2008-08-29 21:18:38 +02:00
committed by Junio C Hamano
parent 6534703059
commit 498bcd3159
3 changed files with 60 additions and 21 deletions

View File

@ -53,6 +53,7 @@ struct rev_info {
rewrite_parents:1,
print_parents:1,
reverse:1,
reverse_output_stage:1,
cherry_pick:1,
first_parent_only:1;