t/t5505-remote.sh: escape * to prevent interpretation by shell as glob
This test is supposed to check that git-remote correctly refuses to delete all URLS for the specified remote which match the '.*' regular expression. Since the '*' was not protected, it was interpreted by the shell as a file glob and expanded before being passed to git-remote. The call to git-remote still exited non-zero in this case, and the overall test still passed, but it exited non-zero because git-remote was passed the incorrect number of arguments, not for the reason it was supposed to fail. Correct the test by escaping the '*'. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
		
				
					committed by
					
						
						Junio C Hamano
					
				
			
			
				
	
			
			
			
						parent
						
							f3b1fbf860
						
					
				
				
					commit
					49de47cfb2
				
			@ -662,7 +662,7 @@ test_expect_success 'remote set-url --add bbb' '
 | 
				
			|||||||
'
 | 
					'
 | 
				
			||||||
 | 
					
 | 
				
			||||||
test_expect_success 'remote set-url --delete .*' '
 | 
					test_expect_success 'remote set-url --delete .*' '
 | 
				
			||||||
	test_must_fail git remote set-url --delete someremote .* &&
 | 
						test_must_fail git remote set-url --delete someremote .\* &&
 | 
				
			||||||
	echo "YYY" >expect &&
 | 
						echo "YYY" >expect &&
 | 
				
			||||||
	echo baz >>expect &&
 | 
						echo baz >>expect &&
 | 
				
			||||||
	echo bbb >>expect &&
 | 
						echo bbb >>expect &&
 | 
				
			||||||
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user