mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

strbuf: fix urlencode format string on signed char

Browse Source 
Git credential fails with special char in password with

    remote: Invalid username or password.
    fatal: Authentication failed for

    File ~/.git-credential contains badly urlencoded characters
    %ffffffXX%ffffffYY instead of %XX%YY.

Add a cast to an unsigned char to fix urlencode use of %02x on a
char.

Signed-off-by: Julien Dusser <julien.dusser@free.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Julien Dusser
2017-12-22 18:24:37 +01:00
committed by Junio C Hamano
parent 3013dff866
commit 4c267f2ae3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
strbuf.c
View File

@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len,
(!reserved && is_rfc3986_reserved(ch))) (!reserved && is_rfc3986_reserved(ch)))
strbuf_addch(sb, ch); strbuf_addch(sb, ch);
else else
strbuf_addf(sb, "%%%02x", ch); strbuf_addf(sb, "%%%02x", (unsigned char)ch);
} }
} }