From 4cf67ae1b6c80eb8a63cc8dd752bd3951cffa104 Mon Sep 17 00:00:00 2001 From: Joel Holdsworth Date: Thu, 16 Dec 2021 13:46:18 +0000 Subject: [PATCH] git-p4: open temporary patch file for write only The patchRCSKeywords method creates a temporary file in which to store the patched output data. Previously this file was opened in "w+" mode (write and read), but the code never reads the contents of the file while open, so it only needs to be opened in "w" mode (write-only). Signed-off-by: Joel Holdsworth Signed-off-by: Junio C Hamano --- git-p4.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-p4.py b/git-p4.py index 509feac2d8..7845210e69 100755 --- a/git-p4.py +++ b/git-p4.py @@ -1754,7 +1754,7 @@ class P4Submit(Command, P4UserMap): # Attempt to zap the RCS keywords in a p4 controlled file matching the given regex (handle, outFileName) = tempfile.mkstemp(dir='.') try: - with os.fdopen(handle, "w+") as outFile, open(file, "r") as inFile: + with os.fdopen(handle, "w") as outFile, open(file, "r") as inFile: for line in inFile.readlines(): outFile.write(regexp.sub(r'$\1$', line)) # Forcibly overwrite the original file