mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vcs-svn: eliminate global byte_buffer

Browse Source 
The data stored in byte_buffer[] is always either discarded or
written to stdout immediately.  No need for it to persist between
function calls.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This commit is contained in:
Jonathan Nieder
2010-10-10 21:37:10 -05:00
parent 8dc6a373d2
commit 4d21bec0d2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
vcs-svn/line_buffer.c
View File

@ -14,7 +14,6 @@
obj_pool_gen(blob, char, 4096) obj_pool_gen(blob, char, 4096)
static char line_buffer[LINE_BUFFER_LEN]; static char line_buffer[LINE_BUFFER_LEN];
static char byte_buffer[COPY_BUFFER_LEN];
static FILE *infile; static FILE *infile;
int buffer_init(const char *filename) int buffer_init(const char *filename)
@ -68,6 +67,7 @@ char *buffer_read_string(uint32_t len)
void buffer_copy_bytes(uint32_t len) void buffer_copy_bytes(uint32_t len)
{ {
char byte_buffer[COPY_BUFFER_LEN];
uint32_t in; uint32_t in;
while (len > 0 && !feof(infile) && !ferror(infile)) { while (len > 0 && !feof(infile) && !ferror(infile)) {
in = len < COPY_BUFFER_LEN ? len : COPY_BUFFER_LEN; in = len < COPY_BUFFER_LEN ? len : COPY_BUFFER_LEN;
@ -83,6 +83,7 @@ void buffer_copy_bytes(uint32_t len)
void buffer_skip_bytes(uint32_t len) void buffer_skip_bytes(uint32_t len)
{ {
char byte_buffer[COPY_BUFFER_LEN];
uint32_t in; uint32_t in;
while (len > 0 && !feof(infile) && !ferror(infile)) { while (len > 0 && !feof(infile) && !ferror(infile)) {
in = len < COPY_BUFFER_LEN ? len : COPY_BUFFER_LEN; in = len < COPY_BUFFER_LEN ? len : COPY_BUFFER_LEN;