Do not barf on too long action description
Reflog message is primarily about easier identification, and leaving truncated entry is much better than dying. Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
@ -35,16 +35,13 @@ static int update_ref(const char *action,
|
|||||||
unsigned char *sha1,
|
unsigned char *sha1,
|
||||||
unsigned char *oldval)
|
unsigned char *oldval)
|
||||||
{
|
{
|
||||||
int len;
|
|
||||||
char msg[1024];
|
char msg[1024];
|
||||||
char *rla = getenv("GIT_REFLOG_ACTION");
|
char *rla = getenv("GIT_REFLOG_ACTION");
|
||||||
static struct ref_lock *lock;
|
static struct ref_lock *lock;
|
||||||
|
|
||||||
if (!rla)
|
if (!rla)
|
||||||
rla = "(reflog update)";
|
rla = "(reflog update)";
|
||||||
len = snprintf(msg, sizeof(msg), "%s: %s", rla, action);
|
snprintf(msg, sizeof(msg), "%s: %s", rla, action);
|
||||||
if (sizeof(msg) <= len)
|
|
||||||
die("insanely long action");
|
|
||||||
lock = lock_any_ref_for_update(refname, oldval);
|
lock = lock_any_ref_for_update(refname, oldval);
|
||||||
if (!lock)
|
if (!lock)
|
||||||
return 1;
|
return 1;
|
||||||
|
Reference in New Issue
Block a user