Use hashcpy() when copying object names
We invented hashcpy() to keep the abstraction of "object name" behind it. Use it instead of calling memcpy() with hard-coded 20-byte length when moving object names between pieces of memory. Leave ppc/sha1.c as-is, because the function is about the SHA-1 hash algorithm whose output is and will always be 20 bytes. Helped-by: Michael Haggerty <mhagger@alum.mit.edu> Helped-by: Duy Nguyen <pclouds@gmail.com> Signed-off-by: Sun He <sunheehnus@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
@ -530,7 +530,7 @@ void bitmap_writer_finish(struct pack_idx_entry **index,
|
||||
header.version = htons(default_version);
|
||||
header.options = htons(flags | options);
|
||||
header.entry_count = htonl(writer.selected_nr);
|
||||
memcpy(header.checksum, writer.pack_checksum, 20);
|
||||
hashcpy(header.checksum, writer.pack_checksum);
|
||||
|
||||
sha1write(f, &header, sizeof(header));
|
||||
dump_bitmap(f, writer.commits);
|
||||
|
||||
Reference in New Issue
Block a user