mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use starts_with() for C strings instead of memcmp()

Browse Source 
Convert three cases of checking for a constant prefix using memcmp() to
starts_with().  This way there is no need for magic string length
constants and we avoid running over the end of the string should it be
shorter than the prefix.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe
2014-06-06 19:24:48 +02:00
committed by Junio C Hamano
parent bce14aa132
commit 50e19a8358
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
remote.c
View File

@ -1194,7 +1194,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
case 1:
break;
case 0:
if (!memcmp(dst_value, "refs/", 5))
if (starts_with(dst_value, "refs/"))
matched_dst = make_linked_ref(dst_value, dst_tail);
else if (is_null_sha1(matched_src->new_sha1))
error("unable to delete '%s': remote ref does not exist",