mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit.c: remove print_commit_list()

Browse Source 
The helper function tries to offer a way to conveniently show the
last one differently from others, presumably to allow you to say
something like

	A, B, and C.

while iterating over a list that has these three elements.

However, there is only one caller, and it passes the same format
string "%s\n" for both the last one and the other ones.  Retire the
helper function and update the caller with a simplified version.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2016-07-08 10:09:28 -07:00
parent dabd35f4cd
commit 54307ea7c3
3 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bisect.c
View File

@ -646,7 +646,10 @@ static void exit_if_skipped_commits(struct commit_list *tried,
printf("There are only 'skip'ped commits left to test.\n" printf("There are only 'skip'ped commits left to test.\n"
"The first %s commit could be any of:\n", term_bad); "The first %s commit could be any of:\n", term_bad);
print_commit_list(tried, "%s\n", "%s\n");
for ( ; tried; tried = tried->next)
printf("%s\n", oid_to_hex(&tried->item->object.oid));
if (bad) if (bad)
printf("%s\n", oid_to_hex(bad)); printf("%s\n", oid_to_hex(bad));
printf("We cannot bisect more!\n"); printf("We cannot bisect more!\n");

10
commit.c
View File

@ -1617,16 +1617,6 @@ struct commit_list **commit_list_append(struct commit *commit,
return &new->next; return &new->next;
} }
void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last)
{
for ( ; list; list = list->next) {
const char *format = list->next ? format_cur : format_last;
printf(format, oid_to_hex(&list->item->object.oid));
}
}
const char *find_commit_header(const char *msg, const char *key, size_t *out_len) const char *find_commit_header(const char *msg, const char *key, size_t *out_len)
{ {
int key_len = strlen(key); int key_len = strlen(key);

4
commit.h
View File

@ -376,10 +376,6 @@ extern int parse_signed_commit(const struct commit *commit,
struct strbuf *message, struct strbuf *signature); struct strbuf *message, struct strbuf *signature);
extern int remove_signature(struct strbuf *buf); extern int remove_signature(struct strbuf *buf);
extern void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last);
/* /*
* Check the signature of the given commit. The result of the check is stored * Check the signature of the given commit. The result of the check is stored
* in sig->check_result, 'G' for a good signature, 'U' for a good signature * in sig->check_result, 'G' for a good signature, 'U' for a good signature