mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*.[ch]: remove extern from function declarations using spatch

Browse Source 
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.

This was the Coccinelle patch used:

	@@
	type T;
	identifier f;
	@@
	- extern
	  T f(...);

and it was run with:

	$ git ls-files \*.{c,h} |
		grep -v ^compat/ |
		xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place

Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Denton Liu
2019-04-29 04:28:14 -04:00
committed by Junio C Hamano
parent ffac537e6c
commit 554544276a
70 changed files with 885 additions and 885 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkt-line.h
View File

@ -172,7 +172,7 @@ struct packet_reader {
* Initialize a 'struct packet_reader' object which is an
* abstraction around the 'packet_read_with_status()' function.
*/
extern void packet_reader_init(struct packet_reader *reader, int fd,
void packet_reader_init(struct packet_reader *reader, int fd,
char *src_buffer, size_t src_len,
int options);
@ -186,7 +186,7 @@ extern void packet_reader_init(struct packet_reader *reader, int fd,
* 'line' is set to point at the read line
* PACKET_READ_FLUSH: 'pktlen' is set to '0' and 'line' is set to NULL
*/
extern enum packet_read_status packet_reader_read(struct packet_reader *reader);
enum packet_read_status packet_reader_read(struct packet_reader *reader);
/*
* Peek the next packet line without consuming it and return the status.
@ -196,7 +196,7 @@ extern enum packet_read_status packet_reader_read(struct packet_reader *reader);
* Peeking multiple times without calling 'packet_reader_read()' will return
* the same result.
*/
extern enum packet_read_status packet_reader_peek(struct packet_reader *reader);
enum packet_read_status packet_reader_peek(struct packet_reader *reader);
#define DEFAULT_PACKET_MAX 1000
#define LARGE_PACKET_MAX 65520