mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*.c *_init(): define in terms of corresponding *_INIT macro

Browse Source 
Change the common patter in the codebase of duplicating the
initialization logic between an *_INIT macro and a
corresponding *_init() function to use the macro as the canonical
source of truth.

Now we no longer need to keep the function up-to-date with the macro
version. This implements a suggestion by Jeff King who found that
under -O2 [1] modern compilers will init new version in place without
the extra copy[1]. The performance of a single *_init() won't matter
in most cases, but even if it does we're going to be producing
efficient machine code to perform these operations.

1. https://lore.kernel.org/git/YNyrDxUO1PlGJvCn@coredump.intra.peff.net/

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2021-07-01 12:51:26 +02:00
committed by Junio C Hamano
parent 3d97ea479f
commit 5726a6b401
6 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
strmap.c
View File

@ -25,7 +25,8 @@ static struct strmap_entry *find_strmap_entry(struct strmap *map,
void strmap_init(struct strmap *map)
{
strmap_init_with_options(map, NULL, 1);
struct strmap blank = STRMAP_INIT;
memcpy(map, &blank, sizeof(*map));
}
void strmap_init_with_options(struct strmap *map,