xgethostname: handle long hostnames
If the full hostname doesn't fit in the buffer supplied to gethostname, POSIX does not specify whether the buffer will be null-terminated, so to be safe, we should do it ourselves. Introduce new function, xgethostname, which ensures that there is always a \0 at the end of the buffer. Signed-off-by: David Turner <dturner@twosigma.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
da25bdb776
commit
5781a9a270
13
wrapper.c
13
wrapper.c
@ -679,3 +679,16 @@ void sleep_millisec(int millisec)
|
||||
{
|
||||
poll(NULL, 0, millisec);
|
||||
}
|
||||
|
||||
int xgethostname(char *buf, size_t len)
|
||||
{
|
||||
/*
|
||||
* If the full hostname doesn't fit in buf, POSIX does not
|
||||
* specify whether the buffer will be null-terminated, so to
|
||||
* be safe, do it ourselves.
|
||||
*/
|
||||
int ret = gethostname(buf, len);
|
||||
if (!ret)
|
||||
buf[len - 1] = 0;
|
||||
return ret;
|
||||
}
|
||||
|
Reference in New Issue
Block a user