[PATCH] Anal retentive 'const unsigned char *sha1'
Make 'sha1' parameters const where possible Signed-off-by: Jason McMullan <jason.mcmullan@timesys.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

parent
e0f0e891c1
commit
5d6ccf5ce7
2
blob.c
2
blob.c
@ -4,7 +4,7 @@
|
|||||||
|
|
||||||
const char *blob_type = "blob";
|
const char *blob_type = "blob";
|
||||||
|
|
||||||
struct blob *lookup_blob(unsigned char *sha1)
|
struct blob *lookup_blob(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = lookup_object(sha1);
|
struct object *obj = lookup_object(sha1);
|
||||||
if (!obj) {
|
if (!obj) {
|
||||||
|
2
blob.h
2
blob.h
@ -9,7 +9,7 @@ struct blob {
|
|||||||
struct object object;
|
struct object object;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct blob *lookup_blob(unsigned char *sha1);
|
struct blob *lookup_blob(const unsigned char *sha1);
|
||||||
|
|
||||||
int parse_blob_buffer(struct blob *item, void *buffer, unsigned long size);
|
int parse_blob_buffer(struct blob *item, void *buffer, unsigned long size);
|
||||||
|
|
||||||
|
2
cache.h
2
cache.h
@ -167,7 +167,7 @@ extern void * unpack_sha1_file(void *map, unsigned long mapsize, char *type, uns
|
|||||||
extern void * read_sha1_file(const unsigned char *sha1, char *type, unsigned long *size);
|
extern void * read_sha1_file(const unsigned char *sha1, char *type, unsigned long *size);
|
||||||
extern int write_sha1_file(void *buf, unsigned long len, const char *type, unsigned char *return_sha1);
|
extern int write_sha1_file(void *buf, unsigned long len, const char *type, unsigned char *return_sha1);
|
||||||
|
|
||||||
extern int check_sha1_signature(unsigned char *sha1, void *buf, unsigned long size, const char *type);
|
extern int check_sha1_signature(const unsigned char *sha1, void *buf, unsigned long size, const char *type);
|
||||||
|
|
||||||
/* Read a tree into the cache */
|
/* Read a tree into the cache */
|
||||||
extern int read_tree(void *buffer, unsigned long size, int stage);
|
extern int read_tree(void *buffer, unsigned long size, int stage);
|
||||||
|
6
commit.c
6
commit.c
@ -5,7 +5,7 @@
|
|||||||
|
|
||||||
const char *commit_type = "commit";
|
const char *commit_type = "commit";
|
||||||
|
|
||||||
static struct commit *check_commit(struct object *obj, unsigned char *sha1)
|
static struct commit *check_commit(struct object *obj, const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
if (obj->type != commit_type) {
|
if (obj->type != commit_type) {
|
||||||
error("Object %s is a %s, not a commit",
|
error("Object %s is a %s, not a commit",
|
||||||
@ -15,7 +15,7 @@ static struct commit *check_commit(struct object *obj, unsigned char *sha1)
|
|||||||
return (struct commit *) obj;
|
return (struct commit *) obj;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct commit *lookup_commit_reference(unsigned char *sha1)
|
struct commit *lookup_commit_reference(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = parse_object(sha1);
|
struct object *obj = parse_object(sha1);
|
||||||
|
|
||||||
@ -26,7 +26,7 @@ struct commit *lookup_commit_reference(unsigned char *sha1)
|
|||||||
return check_commit(obj, sha1);
|
return check_commit(obj, sha1);
|
||||||
}
|
}
|
||||||
|
|
||||||
struct commit *lookup_commit(unsigned char *sha1)
|
struct commit *lookup_commit(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = lookup_object(sha1);
|
struct object *obj = lookup_object(sha1);
|
||||||
if (!obj) {
|
if (!obj) {
|
||||||
|
4
commit.h
4
commit.h
@ -19,8 +19,8 @@ struct commit {
|
|||||||
|
|
||||||
extern const char *commit_type;
|
extern const char *commit_type;
|
||||||
|
|
||||||
struct commit *lookup_commit(unsigned char *sha1);
|
struct commit *lookup_commit(const unsigned char *sha1);
|
||||||
struct commit *lookup_commit_reference(unsigned char *sha1);
|
struct commit *lookup_commit_reference(const unsigned char *sha1);
|
||||||
|
|
||||||
int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size);
|
int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size);
|
||||||
|
|
||||||
|
2
delta.c
2
delta.c
@ -17,7 +17,7 @@ struct delta {
|
|||||||
} u;
|
} u;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct delta *lookup_delta(unsigned char *sha1)
|
struct delta *lookup_delta(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = lookup_object(sha1);
|
struct object *obj = lookup_object(sha1);
|
||||||
if (!obj) {
|
if (!obj) {
|
||||||
|
2
delta.h
2
delta.h
@ -12,7 +12,7 @@ extern void *patch_delta(void *src_buf, unsigned long src_size,
|
|||||||
/* handling of delta objects */
|
/* handling of delta objects */
|
||||||
struct delta;
|
struct delta;
|
||||||
struct object_list;
|
struct object_list;
|
||||||
extern struct delta *lookup_delta(unsigned char *sha1);
|
extern struct delta *lookup_delta(const unsigned char *sha1);
|
||||||
extern int parse_delta_buffer(struct delta *item, void *buffer, unsigned long size);
|
extern int parse_delta_buffer(struct delta *item, void *buffer, unsigned long size);
|
||||||
extern int parse_delta(struct delta *item, unsigned char sha1);
|
extern int parse_delta(struct delta *item, unsigned char sha1);
|
||||||
extern int process_deltas(void *src, unsigned long src_size,
|
extern int process_deltas(void *src, unsigned long src_size,
|
||||||
|
8
object.c
8
object.c
@ -10,7 +10,7 @@ struct object **objs;
|
|||||||
int nr_objs;
|
int nr_objs;
|
||||||
static int obj_allocs;
|
static int obj_allocs;
|
||||||
|
|
||||||
static int find_object(unsigned char *sha1)
|
static int find_object(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
int first = 0, last = nr_objs;
|
int first = 0, last = nr_objs;
|
||||||
|
|
||||||
@ -31,7 +31,7 @@ static int find_object(unsigned char *sha1)
|
|||||||
return -first-1;
|
return -first-1;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct object *lookup_object(unsigned char *sha1)
|
struct object *lookup_object(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
int pos = find_object(sha1);
|
int pos = find_object(sha1);
|
||||||
if (pos >= 0)
|
if (pos >= 0)
|
||||||
@ -39,7 +39,7 @@ struct object *lookup_object(unsigned char *sha1)
|
|||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
void created_object(unsigned char *sha1, struct object *obj)
|
void created_object(const unsigned char *sha1, struct object *obj)
|
||||||
{
|
{
|
||||||
int pos = find_object(sha1);
|
int pos = find_object(sha1);
|
||||||
|
|
||||||
@ -98,7 +98,7 @@ void mark_reachable(struct object *obj, unsigned int mask)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
struct object *parse_object(unsigned char *sha1)
|
struct object *parse_object(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
unsigned long mapsize;
|
unsigned long mapsize;
|
||||||
void *map = map_sha1_file(sha1, &mapsize);
|
void *map = map_sha1_file(sha1, &mapsize);
|
||||||
|
6
object.h
6
object.h
@ -21,12 +21,12 @@ struct object {
|
|||||||
extern int nr_objs;
|
extern int nr_objs;
|
||||||
extern struct object **objs;
|
extern struct object **objs;
|
||||||
|
|
||||||
struct object *lookup_object(unsigned char *sha1);
|
struct object *lookup_object(const unsigned char *sha1);
|
||||||
|
|
||||||
void created_object(unsigned char *sha1, struct object *obj);
|
void created_object(const unsigned char *sha1, struct object *obj);
|
||||||
|
|
||||||
/** Returns the object, having parsed it to find out what it is. **/
|
/** Returns the object, having parsed it to find out what it is. **/
|
||||||
struct object *parse_object(unsigned char *sha1);
|
struct object *parse_object(const unsigned char *sha1);
|
||||||
|
|
||||||
void add_ref(struct object *refer, struct object *target);
|
void add_ref(struct object *refer, struct object *target);
|
||||||
|
|
||||||
|
@ -266,7 +266,7 @@ static char *find_sha1_file(const unsigned char *sha1, struct stat *st)
|
|||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
int check_sha1_signature(unsigned char *sha1, void *map, unsigned long size, const char *type)
|
int check_sha1_signature(const unsigned char *sha1, void *map, unsigned long size, const char *type)
|
||||||
{
|
{
|
||||||
char header[100];
|
char header[100];
|
||||||
unsigned char real_sha1[20];
|
unsigned char real_sha1[20];
|
||||||
|
2
tag.c
2
tag.c
@ -3,7 +3,7 @@
|
|||||||
|
|
||||||
const char *tag_type = "tag";
|
const char *tag_type = "tag";
|
||||||
|
|
||||||
struct tag *lookup_tag(unsigned char *sha1)
|
struct tag *lookup_tag(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = lookup_object(sha1);
|
struct object *obj = lookup_object(sha1);
|
||||||
if (!obj) {
|
if (!obj) {
|
||||||
|
2
tag.h
2
tag.h
@ -12,7 +12,7 @@ struct tag {
|
|||||||
char *signature; /* not actually implemented */
|
char *signature; /* not actually implemented */
|
||||||
};
|
};
|
||||||
|
|
||||||
extern struct tag *lookup_tag(unsigned char *sha1);
|
extern struct tag *lookup_tag(const unsigned char *sha1);
|
||||||
extern int parse_tag_buffer(struct tag *item, void *data, unsigned long size);
|
extern int parse_tag_buffer(struct tag *item, void *data, unsigned long size);
|
||||||
extern int parse_tag(struct tag *item);
|
extern int parse_tag(struct tag *item);
|
||||||
|
|
||||||
|
2
tree.c
2
tree.c
@ -73,7 +73,7 @@ int read_tree(void *buffer, unsigned long size, int stage)
|
|||||||
return read_tree_recursive(buffer, size, "", 0, stage);
|
return read_tree_recursive(buffer, size, "", 0, stage);
|
||||||
}
|
}
|
||||||
|
|
||||||
struct tree *lookup_tree(unsigned char *sha1)
|
struct tree *lookup_tree(const unsigned char *sha1)
|
||||||
{
|
{
|
||||||
struct object *obj = lookup_object(sha1);
|
struct object *obj = lookup_object(sha1);
|
||||||
if (!obj) {
|
if (!obj) {
|
||||||
|
2
tree.h
2
tree.h
@ -24,7 +24,7 @@ struct tree {
|
|||||||
struct tree_entry_list *entries;
|
struct tree_entry_list *entries;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct tree *lookup_tree(unsigned char *sha1);
|
struct tree *lookup_tree(const unsigned char *sha1);
|
||||||
|
|
||||||
int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size);
|
int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user