mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

get_remote_group(): eliminate superfluous call to strcspn()

Browse Source 
There is no need to call it if value is the empty string. This also
eliminates code duplication.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty
2015-07-28 23:08:20 +02:00
committed by Junio C Hamano
parent e286542de0
commit 5f65499fa2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/fetch.c
View File

@ -976,13 +976,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
if (starts_with(key, "remotes.") && if (starts_with(key, "remotes.") &&
!strcmp(key + 8, g->name)) { !strcmp(key + 8, g->name)) {
/* split list by white space */ /* split list by white space */
size_t wordlen = strcspn(value, " \t\n");
while (*value) { while (*value) {
size_t wordlen = strcspn(value, " \t\n");
if (wordlen >= 1) if (wordlen >= 1)
string_list_append(g->list, string_list_append(g->list,
xstrndup(value, wordlen)); xstrndup(value, wordlen));
value += wordlen + (value[wordlen] != '\0'); value += wordlen + (value[wordlen] != '\0');
wordlen = strcspn(value, " \t\n");
} }
} }