http: allow authenticating proactively
When making a request over HTTP(S), Git only sends authentication if it receives a 401 response. Thus, if a repository is open to the public for reading, Git will typically never ask for authentication for fetches and clones. However, there may be times when a user would like to authenticate nevertheless. For example, a forge may give higher rate limits to users who authenticate because they are easier to contact in case of excessive use. Or it may be useful for a known heavy user, such as an internal service, to proactively authenticate so its use can be monitored and, if necessary, throttled. Let's make this possible with a new option, "http.proactiveAuth". This option specifies a type of authentication which can be used to authenticate against the host in question. This is necessary because we lack the WWW-Authenticate header to provide us details; similarly, we cannot accept certain types of authentication because we require information from the server, such as a nonce or challenge, to successfully authenticate. If we're in auto mode and we got a username and password, set the authentication scheme to Basic. libcurl will not send authentication proactively unless there's a single choice of allowed authentication, and we know in this case we didn't get an authtype entry telling us what scheme to use, or we would have taken a different codepath and written the header ourselves. In any event, of the other schemes that libcurl supports, Digest and NTLM require a nonce or challenge, which means that they cannot work with proactive auth, and GSSAPI does not use a username and password at all, so Basic is the only logical choice among the built-in options. Note that the existing http_proactive_auth variable signifies proactive auth if there are already credentials, which is different from the functionality we're adding, which always seeks credentials even if none are provided. Nonetheless, t5540 tests the existing behavior for WebDAV-based pushes to an open repository without credentials, so we preserve it. While at first this may seem an insecure and bizarre decision, it may be that authentication is done with TLS certificates, in which case it might actually provide a quite high level of security. Expand the variable to use an enum to handle the additional cases and a helper function to distinguish our new cases from the old ones. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
4216329457
commit
610cbc1dfb
@ -56,6 +56,26 @@ http.emptyAuth::
|
||||
a username in the URL, as libcurl normally requires a username for
|
||||
authentication.
|
||||
|
||||
http.proactiveAuth::
|
||||
Attempt authentication without first making an unauthenticated attempt and
|
||||
receiving a 401 response. This can be used to ensure that all requests are
|
||||
authenticated. If `http.emptyAuth` is set to true, this value has no effect.
|
||||
+
|
||||
If the credential helper used specifies an authentication scheme (i.e., via the
|
||||
`authtype` field), that value will be used; if a username and password is
|
||||
provided without a scheme, then Basic authentication is used. The value of the
|
||||
option determines the scheme requested from the helper. Possible values are:
|
||||
+
|
||||
--
|
||||
* `basic` - Request Basic authentication from the helper.
|
||||
* `auto` - Allow the helper to pick an appropriate scheme.
|
||||
* `none` - Disable proactive authentication.
|
||||
--
|
||||
+
|
||||
Note that TLS should always be used with this configuration, since otherwise it
|
||||
is easy to accidentally expose plaintext credentials if Basic authentication
|
||||
is selected.
|
||||
|
||||
http.delegation::
|
||||
Control GSSAPI credential delegation. The delegation is disabled
|
||||
by default in libcurl since version 7.21.7. Set parameter to tell
|
||||
|
Reference in New Issue
Block a user