strbuf: make stripspace() part of strbuf
This function is also used in other builtins than stripspace, so it makes sense to have it in a more generic place. Since it operates on an strbuf and the function is declared in strbuf.h, move it to strbuf.c and add the corresponding prefix to its name, just like other API functions in the strbuf_* family. Also switch all current users of stripspace() to the new function name and keep a temporary wrapper inline function for any topic branches still using stripspace(). Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
22f698cb18
commit
63af4a8446
@ -498,7 +498,7 @@ static void create_tag(const unsigned char *object, const char *tag,
|
||||
}
|
||||
|
||||
if (opt->cleanup_mode != CLEANUP_NONE)
|
||||
stripspace(buf, opt->cleanup_mode == CLEANUP_ALL);
|
||||
strbuf_stripspace(buf, opt->cleanup_mode == CLEANUP_ALL);
|
||||
|
||||
if (!opt->message_given && !buf->len)
|
||||
die(_("no tag message?"));
|
||||
|
Reference in New Issue
Block a user