config: fix leaking comment character config
When the comment line character has been specified multiple times in the configuration, then `git_default_core_config()` will cause a memory leak because it unconditionally copies the string into `comment_line_str` without free'ing the previous value. In fact, it can't easily free the value in the first place because it may contain a string constant. Refactor the code such that we track allocated comment character strings via a separate non-constant variable `comment_line_str_to_free`. Adapt sites that set `comment_line_str` to set both and free the old value that was stored in `comment_line_str_to_free`. This memory leak is being hit in t3404. As there are still other memory leaks in that file we cannot yet mark it as passing with leak checking enabled. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
5f6519b62c
commit
648abbe22d
@ -114,6 +114,7 @@ int protect_ntfs = PROTECT_NTFS_DEFAULT;
|
||||
* that is subject to stripspace.
|
||||
*/
|
||||
const char *comment_line_str = "#";
|
||||
char *comment_line_str_to_free;
|
||||
int auto_comment_line_char;
|
||||
|
||||
/* Parallel index stat data preload? */
|
||||
|
Reference in New Issue
Block a user