mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'win32-filenames-cannot-have-trailing-spaces-or-periods'

Browse Source 
On Windows, filenames cannot have trailing spaces or periods, when
opening such paths, they are stripped automatically. Read: you can open
the file `README` via the file name `README . . .`. This ambiguity can
be used in combination with other security bugs to cause e.g. remote
code execution during recursive clones. This patch series fixes that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2019-09-16 13:26:40 +02:00
parent 5532ebdeb7 d2c84dad1c
commit 65d30a19de
11 changed files with 127 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
t/t7415-submodule-names.sh
View File

@ -102,7 +102,7 @@ test_expect_success MINGW 'prevent git~1 squatting on Windows' '
) &&
test_must_fail git -c core.protectNTFS=false \
clone --recurse-submodules squatting squatting-clone 2>err &&
test_i18ngrep "directory not empty" err &&
test_i18ngrep -e "directory not empty" -e "not an empty directory" err &&
! grep gitdir squatting-clone/d/a/git~2
'