use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling open(2) and die() or die_errno() explicitly. This makes the error messages more consistent and shortens the code. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
a7439d0f9d
commit
66e905b7dd
@ -172,9 +172,7 @@ static void prepare_note_data(const struct object_id *object, struct note_data *
|
||||
|
||||
/* write the template message before editing: */
|
||||
d->edit_path = git_pathdup("NOTES_EDITMSG");
|
||||
fd = open(d->edit_path, O_CREAT | O_TRUNC | O_WRONLY, 0600);
|
||||
if (fd < 0)
|
||||
die_errno(_("could not create file '%s'"), d->edit_path);
|
||||
fd = xopen(d->edit_path, O_CREAT | O_TRUNC | O_WRONLY, 0600);
|
||||
|
||||
if (d->given)
|
||||
write_or_die(fd, d->buf.buf, d->buf.len);
|
||||
|
Reference in New Issue
Block a user