use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling open(2) and die() or die_errno() explicitly. This makes the error messages more consistent and shortens the code. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
a7439d0f9d
commit
66e905b7dd
16
contrib/coccinelle/xopen.cocci
Normal file
16
contrib/coccinelle/xopen.cocci
Normal file
@ -0,0 +1,16 @@
|
||||
@@
|
||||
identifier fd;
|
||||
identifier die_fn =~ "^(die|die_errno)$";
|
||||
@@
|
||||
(
|
||||
fd =
|
||||
- open
|
||||
+ xopen
|
||||
(...);
|
||||
|
|
||||
int fd =
|
||||
- open
|
||||
+ xopen
|
||||
(...);
|
||||
)
|
||||
- if ( \( fd < 0 \| fd == -1 \) ) { die_fn(...); }
|
Reference in New Issue
Block a user