pack-objects: free packing_data in more places
The pack-objects internals use a packing_data struct to track what objects are part of the pack(s) being formed. Since these structures contain allocated fields, failing to appropriately free() them results in a leak. Plug that leak by introducing a clear_packing_data() function, and call it in the appropriate spots. This is a fairly straightforward leak to plug, since none of the callers expect to read any values or have any references to parts of the address space being freed. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
1a87c842ec
commit
66f0c71073
@ -151,6 +151,21 @@ void prepare_packing_data(struct repository *r, struct packing_data *pdata)
|
||||
init_recursive_mutex(&pdata->odb_lock);
|
||||
}
|
||||
|
||||
void clear_packing_data(struct packing_data *pdata)
|
||||
{
|
||||
if (!pdata)
|
||||
return;
|
||||
|
||||
free(pdata->cruft_mtime);
|
||||
free(pdata->in_pack);
|
||||
free(pdata->in_pack_by_idx);
|
||||
free(pdata->in_pack_pos);
|
||||
free(pdata->index);
|
||||
free(pdata->layer);
|
||||
free(pdata->objects);
|
||||
free(pdata->tree_depth);
|
||||
}
|
||||
|
||||
struct object_entry *packlist_alloc(struct packing_data *pdata,
|
||||
const struct object_id *oid)
|
||||
{
|
||||
|
Reference in New Issue
Block a user