add context pointer to read_tree_recursive()
Add a pointer parameter to read_tree_recursive(), which is passed to the callback function. This allows callers of read_tree_recursive() to share data with the callback without resorting to global variables. All current callers pass NULL. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
34533004b2
commit
671f070721
12
tree.c
12
tree.c
@ -29,7 +29,7 @@ static int read_one_entry_opt(const unsigned char *sha1, const char *base, int b
|
||||
return add_cache_entry(ce, opt);
|
||||
}
|
||||
|
||||
static int read_one_entry(const unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode, int stage)
|
||||
static int read_one_entry(const unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode, int stage, void *context)
|
||||
{
|
||||
return read_one_entry_opt(sha1, base, baselen, pathname, mode, stage,
|
||||
ADD_CACHE_OK_TO_ADD|ADD_CACHE_SKIP_DFCHECK);
|
||||
@ -39,7 +39,7 @@ static int read_one_entry(const unsigned char *sha1, const char *base, int basel
|
||||
* This is used when the caller knows there is no existing entries at
|
||||
* the stage that will conflict with the entry being added.
|
||||
*/
|
||||
static int read_one_entry_quick(const unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode, int stage)
|
||||
static int read_one_entry_quick(const unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode, int stage, void *context)
|
||||
{
|
||||
return read_one_entry_opt(sha1, base, baselen, pathname, mode, stage,
|
||||
ADD_CACHE_JUST_APPEND);
|
||||
@ -92,7 +92,7 @@ static int match_tree_entry(const char *base, int baselen, const char *path, uns
|
||||
int read_tree_recursive(struct tree *tree,
|
||||
const char *base, int baselen,
|
||||
int stage, const char **match,
|
||||
read_tree_fn_t fn)
|
||||
read_tree_fn_t fn, void *context)
|
||||
{
|
||||
struct tree_desc desc;
|
||||
struct name_entry entry;
|
||||
@ -106,7 +106,7 @@ int read_tree_recursive(struct tree *tree,
|
||||
if (!match_tree_entry(base, baselen, entry.path, entry.mode, match))
|
||||
continue;
|
||||
|
||||
switch (fn(entry.sha1, base, baselen, entry.path, entry.mode, stage)) {
|
||||
switch (fn(entry.sha1, base, baselen, entry.path, entry.mode, stage, context)) {
|
||||
case 0:
|
||||
continue;
|
||||
case READ_TREE_RECURSIVE:
|
||||
@ -126,7 +126,7 @@ int read_tree_recursive(struct tree *tree,
|
||||
retval = read_tree_recursive(lookup_tree(entry.sha1),
|
||||
newbase,
|
||||
baselen + pathlen + 1,
|
||||
stage, match, fn);
|
||||
stage, match, fn, context);
|
||||
free(newbase);
|
||||
if (retval)
|
||||
return -1;
|
||||
@ -174,7 +174,7 @@ int read_tree(struct tree *tree, int stage, const char **match)
|
||||
|
||||
if (!fn)
|
||||
fn = read_one_entry_quick;
|
||||
err = read_tree_recursive(tree, "", 0, stage, match, fn);
|
||||
err = read_tree_recursive(tree, "", 0, stage, match, fn, NULL);
|
||||
if (fn == read_one_entry || err)
|
||||
return err;
|
||||
|
||||
|
Reference in New Issue
Block a user