range-diff/format-patch: refactor check for commit range
Currently, when called with exactly two arguments, `git range-diff` tests for a literal `..` in each of the two. Likewise, the argument provided via `--range-diff` to `git format-patch` is checked in the same manner. However, `<commit>^!` is a perfectly valid commit range, equivalent to `<commit>^..<commit>` according to the `SPECIFYING RANGES` section of gitrevisions[7]. In preparation for allowing more sophisticated ways to specify commit ranges, let's refactor the check into its own function. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
66e871b664
commit
679b5916cd
@ -16,4 +16,12 @@ int show_range_diff(const char *range1, const char *range2,
|
||||
const struct diff_options *diffopt,
|
||||
const struct strvec *other_arg);
|
||||
|
||||
/*
|
||||
* Determine whether the given argument is usable as a range argument of `git
|
||||
* range-diff`, e.g. A..B. Note that this only validates the format but does
|
||||
* _not_ parse it, i.e. it does _not_ look up the specified commits in the
|
||||
* local repository.
|
||||
*/
|
||||
int is_range_diff_range(const char *arg);
|
||||
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user