mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'rs/commit-list-append'

Browse Source 
There is no need for "commit_list_reverse()" function that only invites
inefficient code.

By René Scharfe
* rs/commit-list-append:
  commit: remove commit_list_reverse()
  revision: append to list instead of insert and reverse
  sequencer: export commit_list_append()
This commit is contained in:
Junio C Hamano
2012-04-29 17:51:30 -07:00
parent 5fa8bf6bf9 a81a7fbc1a
commit 6a8989709e
4 changed files with 31 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
revision.c
View File

@ -2075,6 +2075,7 @@ int prepare_revision_walk(struct rev_info *revs)
{
int nr = revs->pending.nr;
struct object_array_entry *e, *list;
struct commit_list **next = &revs->commits;
e = list = revs->pending.objects;
revs->pending.nr = 0;
@ -2085,12 +2086,11 @@ int prepare_revision_walk(struct rev_info *revs)
if (commit) {
if (!(commit->object.flags & SEEN)) {
commit->object.flags |= SEEN;
commit_list_insert(commit, &revs->commits);
next = commit_list_append(commit, next);
}
}
e++;
}
commit_list_reverse(&revs->commits);
commit_list_sort_by_date(&revs->commits);
if (!revs->leak_pending)
free(list);