mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fetch: drop unneeded NULL-check for remote_ref

Browse Source 
Drop the `NULL` check for `remote_ref` in `update_local_ref()`. The
function only has a single caller, and that caller always passes in a
non-`NULL` value.

This fixes a false positive in Coverity.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2023-05-17 13:48:46 +02:00
committed by Junio C Hamano
parent a40449bcd4
commit 6bc7a37e79
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
builtin/fetch.c
View File

@ -953,11 +953,10 @@ static int update_local_ref(struct ref *ref,
* Base this on the remote's ref name, as it's * Base this on the remote's ref name, as it's
* more likely to follow a standard layout. * more likely to follow a standard layout.
*/ */
const char *name = remote_ref ? remote_ref->name : ""; if (starts_with(remote_ref->name, "refs/tags/")) {
if (starts_with(name, "refs/tags/")) {
msg = "storing tag"; msg = "storing tag";
what = _("[new tag]"); what = _("[new tag]");
} else if (starts_with(name, "refs/heads/")) { } else if (starts_with(remote_ref->name, "refs/heads/")) {
msg = "storing head"; msg = "storing head";
what = _("[new branch]"); what = _("[new branch]");
} else { } else {