mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-prompt: fix uninitialized variable

Browse Source 
First use is in the form:  local var; ...; var=$var$whatever...

If the variable was unset (as bash and others do after "local x"),
then it would error if set -u is in effect.

Also, many shells inherit the existing value after "local var"
without init, but in this case it's unlikely to have a prior value.

Now we initialize it.

(local var= is enough, but local var="" is the custom in this file)

Signed-off-by: Avi Halachmi (:avih) <avihpit@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Avi Halachmi (:avih)
2024-08-20 01:48:26 +00:00
committed by Junio C Hamano
parent f037e607a8
commit 6df4b09159
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/completion/git-prompt.sh
View File

@ -116,7 +116,7 @@ printf -v __git_printf_supports_v -- '%s' yes >/dev/null 2>&1
__git_ps1_show_upstream ()
{
local key value
local svn_remote svn_url_pattern count n
local svn_remote svn_url_pattern="" count n
local upstream_type=git legacy="" verbose="" name=""
svn_remote=()