mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diff-lib: tighten show_interdiff()'s interface

Browse Source 
To compute and show an interdiff, show_interdiff() needs only the two
OID's to compare and a diffopts, yet it expects callers to supply an
entire rev_info. The demand for rev_info is not only overkill, but also
places unnecessary burden on potential future callers which might not
otherwise have a rev_info at hand. Address this by tightening its
signature to require only the items it needs instead of a full rev_info.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Sunshine
2020-09-08 03:16:09 -04:00
committed by Junio C Hamano
parent cdffbdc217
commit 72a7239016
4 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
diff.h
View File

@ -600,7 +600,12 @@ int index_differs_from(struct repository *r, const char *def,
const struct diff_flags *flags,
int ita_invisible_in_index);
void show_interdiff(struct rev_info *, int indent);
/*
* Emit an interdiff of two object ID's to 'diff_options.file' optionally
* indented by 'indent' spaces.
*/
void show_interdiff(const struct object_id *, const struct object_id *,
int indent, struct diff_options *);
/*
* Fill the contents of the filespec "df", respecting any textconv defined by