alloc_ref_from_str(): factor out a common pattern of alloc_ref from string

Also fix an underallocation in walker.c::interpret_target().

Signed-off-by: Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Krzysztof Kowalczyk
2008-05-10 16:26:58 -07:00
committed by Junio C Hamano
parent 1f8115b113
commit 737922aa64
6 changed files with 19 additions and 27 deletions

View File

@ -1761,8 +1761,7 @@ static void one_remote_ref(char *refname)
struct ref *ref;
struct object *obj;
ref = alloc_ref(strlen(refname) + 1);
strcpy(ref->name, refname);
ref = alloc_ref_from_str(refname);
if (http_fetch_ref(remote->url, ref) != 0) {
fprintf(stderr,
@ -1894,8 +1893,7 @@ static void add_remote_info_ref(struct remote_ls_ctx *ls)
char *ref_info;
struct ref *ref;
ref = alloc_ref(strlen(ls->dentry_name) + 1);
strcpy(ref->name, ls->dentry_name);
ref = alloc_ref_from_str(ls->dentry_name);
if (http_fetch_ref(remote->url, ref) != 0) {
fprintf(stderr,