Merge branch 'ss/builtin-cleanup'

"git help $cmd" unnecessarily enumerated potential command names
from the filesystem, even when $cmd is known to be a built-in.

Ideas for further optimization, primarily by killing the use of
is_in_cmdlist(), were suggested in the discussion, but they can
come as follow-ups on top of this series.

* ss/builtin-cleanup:
  builtin/help.c: speed up is_git_command() by checking for builtin commands first
  builtin/help.c: call load_command_list() only when it is needed
  git.c: consistently use the term "builtin" instead of "internal command"
This commit is contained in:
Junio C Hamano
2014-01-10 10:33:47 -08:00
4 changed files with 143 additions and 125 deletions

View File

@ -14,8 +14,8 @@ Git:
. Add the external declaration for the function to `builtin.h`.
. Add the command to `commands[]` table in `handle_internal_command()`,
defined in `git.c`. The entry should look like:
. Add the command to the `commands[]` table defined in `git.c`.
The entry should look like:
{ "foo", cmd_foo, <options> },
+