mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serve: rename is_command() to parse_command()

Browse Source 
The is_command() function not only tells us whether the pktline is a
valid command string, but it also parses out the command (and complains
if we see a duplicate). Let's rename it to make those extra functions
a bit more obvious.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2021-09-14 11:30:20 -04:00 committed by Junio C Hamano
parent 0057847208
commit 76804526f9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
serve.c
View File

@ -163,7 +163,7 @@ static int is_valid_capability(const char *key)
return c && c->advertise(the_repository, NULL); return c && c->advertise(the_repository, NULL);
} }
static int is_command(const char *key, struct protocol_capability **command) static int parse_command(const char *key, struct protocol_capability **command)
{ {
const char *out; const char *out;
@ -251,7 +251,7 @@ static int process_request(void)
BUG("Should have already died when seeing EOF"); BUG("Should have already died when seeing EOF");
case PACKET_READ_NORMAL: case PACKET_READ_NORMAL:
/* collect request; a sequence of keys and values */ /* collect request; a sequence of keys and values */
if (is_command(reader.line, &command) || if (parse_command(reader.line, &command) ||
is_valid_capability(reader.line)) is_valid_capability(reader.line))
strvec_push(&keys, reader.line); strvec_push(&keys, reader.line);
else else