Exec git programs without using PATH.
The git suite may not be in PATH (and thus programs such as git-send-pack could not exec git-rev-list). Thus there is a need for logic that will locate these programs. Modifying PATH is not desirable as it result in behavior differing from the user's intentions, as we may end up prepending "/usr/bin" to PATH. - git C programs will use exec*_git_cmd() APIs to exec sub-commands. - exec*_git_cmd() will execute a git program by searching for it in the following directories: 1. --exec-path (as used by "git") 2. The GIT_EXEC_PATH environment variable. 3. $(gitexecdir) as set in Makefile (default value $(bindir)). - git wrapper will modify PATH as before to enable shell scripts to invoke "git-foo" commands. Ideally, shell scripts should use the git wrapper to become independent of PATH, and then modifying PATH will not be necessary. [jc: with minor updates after a brief review.] Signed-off-by: Michal Ostrowski <mostrows@watson.ibm.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
committed by
Junio C Hamano
parent
c884dd9a54
commit
77cb17e940
@ -1,6 +1,7 @@
|
||||
#include "cache.h"
|
||||
#include "run-command.h"
|
||||
#include <sys/wait.h>
|
||||
#include "exec_cmd.h"
|
||||
|
||||
int run_command_v_opt(int argc, char **argv, int flags)
|
||||
{
|
||||
@ -13,9 +14,13 @@ int run_command_v_opt(int argc, char **argv, int flags)
|
||||
int fd = open("/dev/null", O_RDWR);
|
||||
dup2(fd, 0);
|
||||
dup2(fd, 1);
|
||||
close(fd);
|
||||
close(fd);
|
||||
}
|
||||
if (flags & RUN_GIT_CMD) {
|
||||
execv_git_cmd(argv);
|
||||
} else {
|
||||
execvp(argv[0], (char *const*) argv);
|
||||
}
|
||||
execvp(argv[0], (char *const*) argv);
|
||||
die("exec %s failed.", argv[0]);
|
||||
}
|
||||
for (;;) {
|
||||
|
||||
Reference in New Issue
Block a user