Add several uses of get_object_hash.
Convert most instances where the sha1 member of struct object is dereferenced to use get_object_hash. Most instances that are passed to functions that have versions taking struct object_id, such as get_sha1_hex/get_oid_hex, or instances that can be trivially converted to use struct object_id instead, are not converted. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Jeff King <peff@peff.net>
This commit is contained in:

committed by
Jeff King

parent
3c4270107f
commit
7999b2cf77
@ -175,8 +175,8 @@ static int builtin_diff_tree(struct rev_info *revs,
|
||||
*/
|
||||
if (ent1->item->flags & UNINTERESTING)
|
||||
swap = 1;
|
||||
sha1[swap] = ent0->item->sha1;
|
||||
sha1[1 - swap] = ent1->item->sha1;
|
||||
sha1[swap] = get_object_hash(*ent0->item);
|
||||
sha1[1 - swap] = get_object_hash(*ent1->item);
|
||||
diff_tree_sha1(sha1[0], sha1[1], "", &revs->diffopt);
|
||||
log_tree_diff_flush(revs);
|
||||
return 0;
|
||||
@ -196,8 +196,8 @@ static int builtin_diff_combined(struct rev_info *revs,
|
||||
if (!revs->dense_combined_merges && !revs->combine_merges)
|
||||
revs->dense_combined_merges = revs->combine_merges = 1;
|
||||
for (i = 1; i < ents; i++)
|
||||
sha1_array_append(&parents, ent[i].item->sha1);
|
||||
diff_tree_combined(ent[0].item->sha1, &parents,
|
||||
sha1_array_append(&parents, get_object_hash(*ent[i].item));
|
||||
diff_tree_combined(get_object_hash(*ent[0].item), &parents,
|
||||
revs->dense_combined_merges, revs);
|
||||
sha1_array_clear(&parents);
|
||||
return 0;
|
||||
@ -395,7 +395,7 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
|
||||
const char *name = entry->name;
|
||||
int flags = (obj->flags & UNINTERESTING);
|
||||
if (!obj->parsed)
|
||||
obj = parse_object(obj->sha1);
|
||||
obj = parse_object(get_object_hash(*obj));
|
||||
obj = deref_tag(obj, NULL, 0);
|
||||
if (!obj)
|
||||
die(_("invalid object '%s' given."), name);
|
||||
@ -408,7 +408,7 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
|
||||
} else if (obj->type == OBJ_BLOB) {
|
||||
if (2 <= blobs)
|
||||
die(_("more than two blobs given: '%s'"), name);
|
||||
hashcpy(blob[blobs].sha1, obj->sha1);
|
||||
hashcpy(blob[blobs].sha1, get_object_hash(*obj));
|
||||
blob[blobs].name = name;
|
||||
blob[blobs].mode = entry->mode;
|
||||
blobs++;
|
||||
|
Reference in New Issue
Block a user