mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-rebase--merge: don't include absent parent as a base

Browse Source 
Absent this fix, attempts to rebase an orphan branch using "rebase -m"
fails with:

    $ git rebase -m ORPHAN_TARGET_BASE
    First, rewinding head to replay your work on top of it...
    fatal: Could not parse object 'ORPHAN_ROOT_SHA^'
    Unknown exit code (128) from command: git-merge-recursive ORPHAN_ROOT_SHA^ -- HEAD ORPHAN_ROOT_SHA

To fix, this will only include the rebase root's parent as a base if it exists,
so that in cases of rebasing an orphan branch, it is a simple two-way merge.

Note the default rebase behavior does not fail:

    $ git rebase ORPHAN_TARGET_BASE
    First, rewinding head to replay your work on top of it...
    Applying: ORPHAN_ROOT_COMMIT_MSG
    Using index info to reconstruct a base tree...

A few tests were expecting the old behaviour to forbid rebasing such
a history with "rebase -m", which now need to expect them to succeed.

Signed-off-by: Ben Woosley <ben.woosley@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ben Woosley
2016-04-20 18:20:56 +00:00
committed by Junio C Hamano
parent 6a6636270f
commit 79f43447d2
3 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
git-rebase--merge.sh
View File

@ -67,7 +67,9 @@ call_merge () {
GIT_MERGE_VERBOSITY=1 && export GIT_MERGE_VERBOSITY GIT_MERGE_VERBOSITY=1 && export GIT_MERGE_VERBOSITY
fi fi
test -z "$strategy" && strategy=recursive test -z "$strategy" && strategy=recursive
eval 'git-merge-$strategy' $strategy_opts '"$cmt^" -- "$hd" "$cmt"' # If cmt doesn't have a parent, don't include it as a base
base=$(git rev-parse --verify --quiet $cmt^)
eval 'git-merge-$strategy' $strategy_opts $base ' -- "$hd" "$cmt"'
rv=$? rv=$?
case "$rv" in case "$rv" in
0) 0)

9
t/t3402-rebase-merge.sh
View File

@ -85,6 +85,15 @@ test_expect_success 'rebase -Xtheirs' '
! grep 11 original ! grep 11 original
' '
test_expect_success 'rebase -Xtheirs from orphan' '
git checkout --orphan orphan-conflicting master~2 &&
echo "AB $T" >> original &&
git commit -morphan-conflicting original &&
git rebase -Xtheirs master &&
grep AB original &&
! grep 11 original
'
test_expect_success 'merge and rebase should match' ' test_expect_success 'merge and rebase should match' '
git diff-tree -r test-rebase test-merge >difference && git diff-tree -r test-rebase test-merge >difference &&
if test -s difference if test -s difference

4
t/t3421-rebase-topology-linear.sh
View File

@ -253,7 +253,7 @@ test_run_rebase () {
" "
} }
test_run_rebase success '' test_run_rebase success ''
test_run_rebase failure -m test_run_rebase success -m
test_run_rebase success -i test_run_rebase success -i
test_run_rebase success -p test_run_rebase success -p
@ -268,7 +268,7 @@ test_run_rebase () {
" "
} }
test_run_rebase success '' test_run_rebase success ''
test_run_rebase failure -m test_run_rebase success -m
test_run_rebase success -i test_run_rebase success -i
test_run_rebase failure -p test_run_rebase failure -p