Move "--parent" parsing into generic revision.c library code
Not only do we do it in both rev-list.c and git.c, the revision walking code will soon want to know whether we should rewrite parenthood information or not. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
committed by
Junio C Hamano
parent
8eef8e09ce
commit
7b0c996679
6
git.c
6
git.c
@ -283,7 +283,6 @@ static int cmd_log(int argc, const char **argv, char **envp)
|
||||
char *buf = xmalloc(LOGSIZE);
|
||||
static enum cmit_fmt commit_format = CMIT_FMT_DEFAULT;
|
||||
int abbrev = DEFAULT_ABBREV;
|
||||
int show_parents = 0;
|
||||
const char *commit_prefix = "commit ";
|
||||
|
||||
argc = setup_revisions(argc, argv, &rev, "HEAD");
|
||||
@ -294,9 +293,6 @@ static int cmd_log(int argc, const char **argv, char **envp)
|
||||
if (commit_format == CMIT_FMT_ONELINE)
|
||||
commit_prefix = "";
|
||||
}
|
||||
else if (!strcmp(arg, "--parents")) {
|
||||
show_parents = 1;
|
||||
}
|
||||
else if (!strcmp(arg, "--no-abbrev")) {
|
||||
abbrev = 0;
|
||||
}
|
||||
@ -317,7 +313,7 @@ static int cmd_log(int argc, const char **argv, char **envp)
|
||||
while ((commit = get_revision(&rev)) != NULL) {
|
||||
printf("%s%s", commit_prefix,
|
||||
sha1_to_hex(commit->object.sha1));
|
||||
if (show_parents) {
|
||||
if (rev.parents) {
|
||||
struct commit_list *parents = commit->parents;
|
||||
while (parents) {
|
||||
struct object *o = &(parents->item->object);
|
||||
|
||||
Reference in New Issue
Block a user