mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'ab/perl-do-not-abuse-map'

Browse Source 
Perl critique.

* ab/perl-do-not-abuse-map:
  git-send-email: replace "map" in void context with "for"
This commit is contained in:
Junio C Hamano
2021-04-13 15:28:50 -07:00
parent 0623669fc6 b362acf575
commit 7b55441db1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
git-send-email.perl
View File

@ -217,12 +217,12 @@ sub do_edit {
$editor = Git::command_oneline('var', 'GIT_EDITOR'); $editor = Git::command_oneline('var', 'GIT_EDITOR');
} }
if (defined($multiedit) && !$multiedit) { if (defined($multiedit) && !$multiedit) {
map { for (@_) {
system('sh', '-c', $editor.' "$@"', $editor, $_); system('sh', '-c', $editor.' "$@"', $editor, $_);
if (($? & 127) || ($? >> 8)) { if (($? & 127) || ($? >> 8)) {
die(__("the editor exited uncleanly, aborting everything")); die(__("the editor exited uncleanly, aborting everything"));
} }
} @_; }
} else { } else {
system('sh', '-c', $editor.' "$@"', $editor, @_); system('sh', '-c', $editor.' "$@"', $editor, @_);
if (($? & 127) || ($? >> 8)) { if (($? & 127) || ($? >> 8)) {