Teach/Fix pull/fetch -q/-v options
Implement git-pull --quiet and git-pull --verbose by adding the options to git-pull and fixing verbosity handling in git-fetch. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
a0d3ab9c27
commit
7f87aff22c
@ -22,7 +22,7 @@ enum {
|
||||
TAGS_SET = 2
|
||||
};
|
||||
|
||||
static int append, force, keep, update_head_ok, verbose, quiet;
|
||||
static int append, force, keep, update_head_ok, verbosity;
|
||||
static int tags = TAGS_DEFAULT;
|
||||
static const char *depth;
|
||||
static const char *upload_pack;
|
||||
@ -30,8 +30,7 @@ static struct strbuf default_rla = STRBUF_INIT;
|
||||
static struct transport *transport;
|
||||
|
||||
static struct option builtin_fetch_options[] = {
|
||||
OPT__QUIET(&quiet),
|
||||
OPT__VERBOSE(&verbose),
|
||||
OPT__VERBOSITY(&verbosity),
|
||||
OPT_BOOLEAN('a', "append", &append,
|
||||
"append to .git/FETCH_HEAD instead of overwriting"),
|
||||
OPT_STRING(0, "upload-pack", &upload_pack, "PATH",
|
||||
@ -192,7 +191,6 @@ static int s_update_ref(const char *action,
|
||||
|
||||
static int update_local_ref(struct ref *ref,
|
||||
const char *remote,
|
||||
int verbose,
|
||||
char *display)
|
||||
{
|
||||
struct commit *current = NULL, *updated;
|
||||
@ -210,7 +208,7 @@ static int update_local_ref(struct ref *ref,
|
||||
die("object %s not found", sha1_to_hex(ref->new_sha1));
|
||||
|
||||
if (!hashcmp(ref->old_sha1, ref->new_sha1)) {
|
||||
if (verbose)
|
||||
if (verbosity > 0)
|
||||
sprintf(display, "= %-*s %-*s -> %s", SUMMARY_WIDTH,
|
||||
"[up to date]", REFCOL_WIDTH, remote,
|
||||
pretty_ref);
|
||||
@ -366,18 +364,19 @@ static int store_updated_refs(const char *url, const char *remote_name,
|
||||
note);
|
||||
|
||||
if (ref)
|
||||
rc |= update_local_ref(ref, what, verbose, note);
|
||||
rc |= update_local_ref(ref, what, note);
|
||||
else
|
||||
sprintf(note, "* %-*s %-*s -> FETCH_HEAD",
|
||||
SUMMARY_WIDTH, *kind ? kind : "branch",
|
||||
REFCOL_WIDTH, *what ? what : "HEAD");
|
||||
if (*note) {
|
||||
if (!shown_url) {
|
||||
if (verbosity >= 0 && !shown_url) {
|
||||
fprintf(stderr, "From %.*s\n",
|
||||
url_len, url);
|
||||
shown_url = 1;
|
||||
}
|
||||
fprintf(stderr, " %s\n", note);
|
||||
if (verbosity >= 0)
|
||||
fprintf(stderr, " %s\n", note);
|
||||
}
|
||||
}
|
||||
fclose(fp);
|
||||
@ -637,9 +636,9 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
|
||||
remote = remote_get(argv[0]);
|
||||
|
||||
transport = transport_get(remote, remote->url[0]);
|
||||
if (verbose >= 2)
|
||||
if (verbosity >= 2)
|
||||
transport->verbose = 1;
|
||||
if (quiet)
|
||||
if (verbosity < 0)
|
||||
transport->verbose = -1;
|
||||
if (upload_pack)
|
||||
set_option(TRANS_OPT_UPLOADPACK, upload_pack);
|
||||
|
||||
Reference in New Issue
Block a user