mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

path-utils test: rename mingw_path function to print_path

Browse Source 
mingw_path was introduced in abd4284 to output a mangled path as it is
passed as an argument to main(). But the name is misleading because
mangling does not come from MinGW, but from MSYS [1]. As abd4284 does not
introduce any MSYS or MinGW specific code but just prints out argv[2] as
it is passed to main(), give the function the more generic and less
confusing name "print_path".

[1] http://www.mingw.org/wiki/Posix_path_conversion

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This commit is contained in:
Sebastian Schuberth
2013-10-10 22:49:43 +02:00
committed by Jonathan Nieder
parent f85f7947c3
commit 7ffd18fce1
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
t/t0060-path-utils.sh
View File

@ -8,13 +8,13 @@ test_description='Test various path utilities'
. ./test-lib.sh . ./test-lib.sh
norm_path() { norm_path() {
expected=$(test-path-utils mingw_path "$2") expected=$(test-path-utils print_path "$2")
test_expect_success $3 "normalize path: $1 => $2" \ test_expect_success $3 "normalize path: $1 => $2" \
"test \"\$(test-path-utils normalize_path_copy '$1')\" = '$expected'" "test \"\$(test-path-utils normalize_path_copy '$1')\" = '$expected'"
} }
relative_path() { relative_path() {
expected=$(test-path-utils mingw_path "$3") expected=$(test-path-utils print_path "$3")
test_expect_success $4 "relative path: $1 $2 => $3" \ test_expect_success $4 "relative path: $1 $2 => $3" \
"test \"\$(test-path-utils relative_path '$1' '$2')\" = '$expected'" "test \"\$(test-path-utils relative_path '$1' '$2')\" = '$expected'"
} }

2
test-path-utils.c
View File

@ -116,7 +116,7 @@ int main(int argc, char **argv)
return 0; return 0;
} }
if (argc == 3 && !strcmp(argv[1], "mingw_path")) { if (argc == 3 && !strcmp(argv[1], "print_path")) {
puts(argv[2]); puts(argv[2]);
return 0; return 0;
} }