correct argument checking test for git hash-object
Because the file name given to stdin did not exist, git hash-object fails to open it and exits with non-zero error code. Thus the test may pass even if there is an error in argument checking. Signed-off-by: Dmitry Potapov <dpotapov@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
43df4f86e0
commit
81014073f2
@ -49,16 +49,16 @@ setup_repo
|
|||||||
# Argument checking
|
# Argument checking
|
||||||
|
|
||||||
test_expect_success "multiple '--stdin's are rejected" '
|
test_expect_success "multiple '--stdin's are rejected" '
|
||||||
test_must_fail git hash-object --stdin --stdin < example
|
echo example | test_must_fail git hash-object --stdin --stdin
|
||||||
'
|
'
|
||||||
|
|
||||||
test_expect_success "Can't use --stdin and --stdin-paths together" '
|
test_expect_success "Can't use --stdin and --stdin-paths together" '
|
||||||
test_must_fail git hash-object --stdin --stdin-paths &&
|
echo example | test_must_fail git hash-object --stdin --stdin-paths &&
|
||||||
test_must_fail git hash-object --stdin-paths --stdin
|
echo example | test_must_fail git hash-object --stdin-paths --stdin
|
||||||
'
|
'
|
||||||
|
|
||||||
test_expect_success "Can't pass filenames as arguments with --stdin-paths" '
|
test_expect_success "Can't pass filenames as arguments with --stdin-paths" '
|
||||||
test_must_fail git hash-object --stdin-paths hello < example
|
echo example | test_must_fail git hash-object --stdin-paths hello
|
||||||
'
|
'
|
||||||
|
|
||||||
# Behavior
|
# Behavior
|
||||||
|
Reference in New Issue
Block a user