mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

contrib/git-credential-gnome-keyring.c: report failure to store password

Browse Source 
Produce an error message when we fail to store a password to the keyring.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Casey
2013-09-23 11:49:15 -07:00
committed by Junio C Hamano
parent 3006297a0e
commit 81c57e2c9d
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
View File

@ -125,6 +125,7 @@ static int keyring_store(struct credential *c)
{ {
guint32 item_id; guint32 item_id;
char *object = NULL; char *object = NULL;
GnomeKeyringResult result;
/* /*
* Sanity check that what we are storing is actually sensible. * Sanity check that what we are storing is actually sensible.
@ -139,7 +140,7 @@ static int keyring_store(struct credential *c)
object = keyring_object(c); object = keyring_object(c);
gnome_keyring_set_network_password_sync( result = gnome_keyring_set_network_password_sync(
GNOME_KEYRING_DEFAULT, GNOME_KEYRING_DEFAULT,
c->username, c->username,
NULL /* domain */, NULL /* domain */,
@ -152,6 +153,13 @@ static int keyring_store(struct credential *c)
&item_id); &item_id);
g_free(object); g_free(object);
if (result != GNOME_KEYRING_RESULT_OK &&
result != GNOME_KEYRING_RESULT_CANCELLED) {
g_critical("%s", gnome_keyring_result_to_message(result));
return EXIT_FAILURE;
}
return EXIT_SUCCESS; return EXIT_SUCCESS;
} }