pkt-line: rename packet_write() to packet_write_fmt()
packet_write() should be called packet_write_fmt() because it is a printf-like function that takes a format string as first parameter. packet_write_fmt() should be used for text strings only. Arbitrary binary data should use a new packet_write() function that is introduced in a subsequent patch. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
ac2fbaa674
commit
81c634e94f
@ -88,11 +88,11 @@ int cmd_upload_archive(int argc, const char **argv, const char *prefix)
|
||||
writer.git_cmd = 1;
|
||||
if (start_command(&writer)) {
|
||||
int err = errno;
|
||||
packet_write(1, "NACK unable to spawn subprocess\n");
|
||||
packet_write_fmt(1, "NACK unable to spawn subprocess\n");
|
||||
die("upload-archive: %s", strerror(err));
|
||||
}
|
||||
|
||||
packet_write(1, "ACK\n");
|
||||
packet_write_fmt(1, "ACK\n");
|
||||
packet_flush(1);
|
||||
|
||||
while (1) {
|
||||
|
Reference in New Issue
Block a user