mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chainlint.pl: don't flag broken &&-chain if failure indicated explicitly

Browse Source 
There are quite a few tests which print an error messages and then
explicitly signal failure with `false`, `return 1`, or `exit 1` as the
final command in an `if` branch. In these cases, the tests don't bother
maintaining the &&-chain between `echo` and the explicit "test failed"
indicator. Since such constructs are manually signaling failure, their
&&-chain breakage is legitimate and safe -- both for the command
immediately preceding `false`, `return`, or `exit`, as well as for all
preceding commands in the `if` branch. Therefore, stop flagging &&-chain
breakage in these sorts of cases.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Sunshine
2022-09-01 00:29:49 +00:00
committed by Junio C Hamano
parent a8f30ee050
commit 832c68b3c2
7 changed files with 62 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
t/chainlint/chain-break-false.test Normal file
View File

@ -0,0 +1,10 @@
# LINT: broken &&-chain okay if explicit "false" signals failure
if condition not satisified
then
echo it did not work...
echo failed!
false
else
echo it went okay
congratulate user
fi