Merge branch 'ab/run-command'

API clean-up.

* ab/run-command:
  run-command API: remove "env" member, always use "env_array"
  difftool: use "env_array" to simplify memory management
  run-command API: remove "argv" member, always use "args"
  run-command API users: use strvec_push(), not argv construction
  run-command API users: use strvec_pushl(), not argv construction
  run-command tests: use strvec_pushv(), not argv assignment
  run-command API users: use strvec_pushv(), not argv assignment
  upload-archive: use regular "struct child_process" pattern
  worktree: stop being overly intimate with run_command() internals
This commit is contained in:
Junio C Hamano
2021-12-15 09:39:47 -08:00
33 changed files with 157 additions and 223 deletions

View File

@ -794,7 +794,7 @@ static void fill_alternate_refs_command(struct child_process *cmd,
}
}
cmd->env = local_repo_env;
strvec_pushv(&cmd->env_array, (const char **)local_repo_env);
cmd->out = -1;
}